Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Fix versioning for S3 bucket #263

Closed
wants to merge 1 commit into from
Closed

Conversation

T0tt1
Copy link

@T0tt1 T0tt1 commented Feb 22, 2022

New Provider expect separate resource for versioning instead of place the statement inside the resource for bucket createtion.

Description

Newest version of TF Provider introduced some changes into the way we manage S3 bucket and its policies, versioning and acl. This PR aims to fix the discrepancy which has been presented once the new provider has been introduced.

Documentation

TODOs

Please ensure all of these TODOs are completed before asking for a review.

  • Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
  • Update the docs.
  • Keep the changes backward compatible where possible.
  • Run the pre-commit checks successfully.
  • Run the relevant tests successfully.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.

Related Issues

Fixes #262

New Provider expect separate resource for versioning instead of place the statement inside the resource for bucket createtion.
@T0tt1 T0tt1 requested a review from robmorgan as a code owner February 22, 2022 13:48
@T0tt1 T0tt1 closed this Feb 22, 2022
@T0tt1 T0tt1 deleted the patch-1 branch February 22, 2022 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform Provider got updated and s3 bucket res changes exists
1 participant